Re: Support for 8-byte TOAST values (aka the TOAST infinite loop problem) - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: Support for 8-byte TOAST values (aka the TOAST infinite loop problem)
Date
Msg-id aV2WL3ciOySe0PLi@paquier.xyz
Whole thread Raw
In response to Re: Support for 8-byte TOAST values (aka the TOAST infinite loop problem)  (Nikhil Kumar Veldanda <veldanda.nikhilkumar17@gmail.com>)
Responses Re: Support for 8-byte TOAST values (aka the TOAST infinite loop problem)
Re: Support for 8-byte TOAST values (aka the TOAST infinite loop problem)
List pgsql-hackers
On Sun, Jan 04, 2026 at 11:39:28PM -0800, Nikhil Kumar Veldanda wrote:
> Semantics: the regression test accepts '-1040' and wraps modulo 2^64.
> Is that intentional? If yes, please document it; if not, oid8in()
> should reject negative input and the test should expect an error.

Yes, like for the oid type this is intentional.

> Nits: oid8.c appears to include <ctype.h> / <limits.h> without using
> them, and there’s an empty src/test/regress/expected/oid8.sql
> (intentional?).

Indeed, I'll clean up that.  Thanks.
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: surya poondla
Date:
Subject: Re: [PATCH] psql: tab completion for ALTER ROLE ... IN DATABASE ...
Next
From: Jeff Davis
Date:
Subject: small cleanup of ICU includes