Re: A small problem when rehashing catalog cache - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: A small problem when rehashing catalog cache
Date
Msg-id aUIk-Sht-VsN4oZz@paquier.xyz
Whole thread Raw
In response to Re: A small problem when rehashing catalog cache  ("cca5507" <cca5507@qq.com>)
Responses Re: A small problem when rehashing catalog cache
List pgsql-hackers
On Wed, Dec 17, 2025 at 11:12:46AM +0800, cca5507 wrote:
> Although this does not affect correctness, I'd like to propose a
> patch to fix it.

That's an interesting point.

Indeed, the code bothers putting a fresh matching entry at the
beginning of a bucket, and the code does the opposite when moving
entries around, which is inconsistent to say the least.  If we move
the entries at the tail instead as you are suggesting the "freshness"
would be preserved better.  This deserves a comment, at least.

20cb18db4668 has added the RehashCatCache() part, with 473182c9523a
copying the same pattern for RehashCatCacheLists().

Thoughts or opinions from others?
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Noah Misch
Date:
Subject: Re: Inval reliability, especially for inplace updates
Next
From: shveta malik
Date:
Subject: Re: Replace is_publishable_class() with relispublishable column in pg_class