Re: Change the signature of pgstat_report_vacuum() so that it's passed a Relation - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: Change the signature of pgstat_report_vacuum() so that it's passed a Relation
Date
Msg-id aUIaDDEiz8khGy30@paquier.xyz
Whole thread Raw
In response to Re: Change the signature of pgstat_report_vacuum() so that it's passed a Relation  (Andres Freund <andres@anarazel.de>)
List pgsql-hackers
On Tue, Dec 16, 2025 at 09:55:09AM -0500, Andres Freund wrote:
> On 2025-12-16 09:45:34 +0000, Bertrand Drouvot wrote:
>> But, we can't do the same for pgstat_report_analyze() because pgstat_should_count_relation()
>> can modify the relation through pgstat_assoc_relation(). So I'm inclined to
>> let it as in v1. Thoughts?
>
> I think const markings for things like this just means more code churn or ugly
> casts when it inevitably ends up not working at some point.

I'm unconvinced as well by the addition of some consts here, so I've
applied v1.
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Thomas Munro
Date:
Subject: Re: [PATCH] Fix ARM64/MSVC atomic memory ordering issues on Win11 by adding explicit DMB ?barriers
Next
From: Tom Lane
Date:
Subject: Re: [PATCH] Allow complex data for GUC extra.