Re: Fix memory leak in tzparser.c - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: Fix memory leak in tzparser.c
Date
Msg-id aUERZ_xGYW8vjwFQ@paquier.xyz
Whole thread Raw
In response to Fix memory leak in tzparser.c  (Shixin Wang <wang-shi-xin@outlook.com>)
List pgsql-hackers
On Tue, Dec 16, 2025 at 05:55:32AM +0000, Shixin Wang wrote:
> While the memory is managed by a temp memory context that gets cleaned up
> eventually, the coarse-grained management might cause some memory to
> accumulate during ParseTzFile() recursive calls when processing @INCLUDE
> directives.
>
> I've attached a patch with this change in case anyone thinks it's worth
> applying.

Why does it matter?  load_tzoffsets() is the sole caller of
ParseTzFile() and it uses a temporary memory context named
TZParserMemory to not have to do cleanups like the one you are
proposing here.
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: [PATCH]Remove the redundant assignment
Next
From: Zsolt Parragi
Date:
Subject: Re: Periodic authorization expiration checks using GoAway message