Re: Switch buffile.c/h to use pgoff_t - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: Switch buffile.c/h to use pgoff_t
Date
Msg-id aU3MfBO_4umfxgE6@paquier.xyz
Whole thread Raw
In response to Re: Switch buffile.c/h to use pgoff_t  (Chao Li <li.evan.chao@gmail.com>)
Responses Re: Switch buffile.c/h to use pgoff_t
List pgsql-hackers
On Thu, Dec 25, 2025 at 10:40:02AM +0800, Chao Li wrote:
> In attached v3, I have applied int64 to the 2 struct fields and
> corresponding local variables. I ran a clean build, no warning was
> introduced, and "make check" passed.

The advantage of being able to make the code transparently more
pluggable for max large sizes while we already use 8-byte offsets is
kind of nice, I guess.  "availbytes" is a clarification bonus as it is
not an offset per-se.  I can see that you have missed on cast spot, so
adjusted things a bit, then applied the result.
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: [PATCH] Optionally record Plan IDs to track plan changes for a query
Next
From: Xuneng Zhou
Date:
Subject: Re: Implement waiting for wal lsn replay: reloaded