On Fri, Dec 12, 2025 at 06:41:20PM -0600, Sami Imseih wrote:
> I made some changes as well, in v8:
>
> 1/ looks like b4cbc106a6ce snuck into v7. I fixed that.
Oops, sorry about that. I went one reset too deep.. I can see that
my local branch was also wrong, an a rebase fixed it immediately.
> 2/ After looking this over, I realized that “extra” and “auxiliary”
> were being used interchangeably. To avoid confusion, I replaced all
> instances of “extra” with “auxiliary" in both the comments and
> macros, i.e. TEST_CUSTOM_AUX_DATA_DESC
I can see what you have changed in v8 compared to v7, in terms of the
elog(), the comments and TEST_CUSTOM_AUX_DATA_DESC. That works for
me. If somebody has a better idea for a name, these can always be
tweaked at will.
--
Michael
