On Sun, Dec 07, 2025 at 11:15:13PM -0500, Tom Lane wrote:
> I think that this is really a bug in the Xversion-update test, because
> I don't see why we'd be holding src/test/modules libraries to the
> standard of can-be-upgraded-across-versions. But maybe there's
> something I'm missing?
Yes, I've noticed that a couple of minutes ago, trying to make heads
and tails out of it. I thought that the tets modules libraries were
not getting pulled in the cross-version upgrades but here we are.
From what I can see, this specific failure is caused by
src/test/modules/gin/ where the module has forgotten to drop the
extension injection_points, but there is a total of three modules that
could have hit the problem, as of:
- src/test/modules/nbtree/ (could be hit in the future as it uses
injection_points).
- src/test/modules/gin/
- src/test/modules/typcache/
And I was wondering whether I should just plant more items in
AdjustUpgrade.pm, like in the attached. We need that for gin when
dealing with an old server of at least v17, and for typcache with v18.
The nbtree test is so recent that it does not matter.
TestUpgradeXversion.pm has an ON_ERROR_STOP=1 so the version check is
required.
--
Michael
