Re: pgsql: Add pg_atomic_unlocked_write_u64 - Mailing list pgsql-hackers

From Nathan Bossart
Subject Re: pgsql: Add pg_atomic_unlocked_write_u64
Date
Msg-id aTGwysvF2lDmK2lP@nathan
Whole thread Raw
In response to Re: pgsql: Add pg_atomic_unlocked_write_u64  (Andres Freund <andres@anarazel.de>)
Responses Re: pgsql: Add pg_atomic_unlocked_write_u64
List pgsql-hackers
On Thu, Dec 04, 2025 at 10:56:12AM -0500, Andres Freund wrote:
> The whole point of the _unlocked_ function is to use it for modifying an
> atomic that doesn't need to actually be atomic when modified by that
> function. The current use-case for it is to to modify BufferDesc->state for
> temporary table buffers. Those obviously can't be shared across processes and
> therefore don't need an atomic operation to be modified. In the referenced
> thread I'm working on converting BufferDesc->state to be a 64bit atomic, hence
> the need for pg_atomic_unlocked_write_u64().
> 
> I didn't notice that the comment for pg_atomic_unlocked_write_u32() makes that
> claim about partial writes not being visible. I think we should just remove
> that claim.

+1 to updating the comment with this context.

-- 
nathan



pgsql-hackers by date:

Previous
From: Andres Freund
Date:
Subject: Re: pgsql: Add pg_atomic_unlocked_write_u64
Next
From: Amit Langote
Date:
Subject: Re: Segmentation fault on proc exit after dshash_find_or_insert