On Tue, Nov 25, 2025 at 04:59:28PM +0800, Chao Li wrote:
> I don’t see any of my comments are addressed in v18.
Sorry about that, I thought that v17 was addressing these. I have
reviewed your latest email posted here:
https://www.postgresql.org/message-id/2C8A20C7-4E08-41F4-B30E-AD9F8B007AE5@gmail.com
And well, this presents a bunch of issues I have already fixed (break
after return, one error message incorrect, some descriptions). The
comments on top of the functions are actually true as they stand (aka
ndistinct_array_end() fails if we don't have an array). There is no
need to reset state vars upon a JSON_SEM_ACTION_FAILED AFAIK.
Finally, the consts are non-appealing for me for functions that are
internally used in these files. And forgot one:
valid_subsequent_attnum()'s duplication is actually adapted IMO, the
argument lists could have different assumptions depending on the type
of extended stats we are dealing with. I did not check the comments
for 0003~0005. Perhaps you are right that these need adjustments.
Thanks,
--
Michael
