split tablecmds.c - Mailing list pgsql-hackers

From Nathan Bossart
Subject split tablecmds.c
Date
Msg-id aS3PeXHLe7ir_gPc@nathan
Whole thread Raw
Responses Re: split tablecmds.c
Re: split tablecmds.c
List pgsql-hackers
This file has over 22,000 lines and is too large to be included in GitHub's
code search results [0].  It appears to have been given its current form in
2002 by commit 71dc300.  Previously, it was named command.c, which dates
back to the 80s.  Is it time to split it into a few different files,
similar to what was done to copy.c in 2020 by commit c532d15?

After briefly skimming through it, some areas that seem like they could
potentially be moved out are partitions, constraints, permission checks,
inheritance, foreign keys, column expressions, table rewriting, attribute
merging, TRUNCATE, and CREATE TABLE.  This is far from a concrete proposal,
but I first wanted to gauge interest in $SUBJECT.

[0] https://docs.github.com/en/search-github/github-code-search/about-github-code-search#limitations

-- 
nathan



pgsql-hackers by date:

Previous
From: tushar
Date:
Subject: Re: Non-text mode for pg_dumpall
Next
From: Jacob Champion
Date:
Subject: Re: Remove useless casting to the same type