On Tue, Nov 18, 2025 at 08:31:41AM +0900, Michael Paquier wrote:
> Hmm. We should try to conclude over the benefit of TAP over
> isolation, and merge both patches together if the consensus is towards
> a TAP test.
>
> The isolation test feels much cleaner to me in terms of clarity and
> debugging output compared to the suggested TAP test as there are many
> SQL sequences the test depends on. Other opinions?
By the way, an extra argument in favor of an isolation test here: the
proposed TAP tests only wants to make sure that replay is able to
finish on a standby, we don't query it. We are already doing the same
in 027_stream_regress.pl for the main regression test suite, and we
could expand this TAP test or add a new one that grabs the isolation
test suite and runs it in a TAP test with a standby plugged. Hence we
would automatically test the replay path for all isolation tests added
to the tree, including this one related to kill tuples.
--
Michael
