Re: Extend injection_points_attach() to accept a user-defined function - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: Extend injection_points_attach() to accept a user-defined function
Date
Msg-id aQ_T2zQEF4_HxST9@paquier.xyz
Whole thread Raw
In response to Re: Extend injection_points_attach() to accept a user-defined function  (Rahila Syed <rahilasyed90@gmail.com>)
Responses Re: Extend injection_points_attach() to accept a user-defined function
List pgsql-hackers
On Fri, Nov 07, 2025 at 05:39:57PM +0530, Rahila Syed wrote:
> OK, it makes sense to leave it out of this function for now. Since
> pgstat_create_inj() currently only tracks the number of runs, it also
> depends on any callback using the appropriate pgstat_report_* API
> from the injection_point module. Without this, setting up the stats
> infrastructure wouldn't be useful.

Yeah.  What you are doing would be enough on simplicity ground.  The
test added is also fine enough, it's safe to run even under an
installcheck.  So LGTM to use a minimal implementation.  Any thoughts
from others?
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: [PATCH] Fix text in comment of copyto.c
Next
From: Thomas Munro
Date:
Subject: Re: MSVC: Improve warning options set