Re: make -C src/test/isolation failure in index-killtuples due to btree_gist - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: make -C src/test/isolation failure in index-killtuples due to btree_gist
Date
Msg-id aQB3BUxe23YiIOyx@paquier.xyz
Whole thread Raw
In response to Re: make -C src/test/isolation failure in index-killtuples due to btree_gist  (Andres Freund <andres@anarazel.de>)
List pgsql-hackers
On Fri, Aug 22, 2025 at 07:46:43PM -0400, Andres Freund wrote:
> That would be the easiest fix - but I'm starting to wonder if it shouldn't
> just be its own test module, as annoying as the boilerplate for that is.
>
> While the test improved code coverage for the various indexes noticeably, I
> did subsequently realize that the new test doesn't end up testing the recovery
> path :(. Better than nothing, but having any coverage of those paths might be
> worth the boilerplate and the runtime overhead of a test module :/

Adding just an EXTRA_INSTALL to isolation's Makefile would not work,
no?  This Makefile has its own rules, which implies that fixing this
issue would be to duplicate what EXTRA_INSTALL does if we don't use
the test module solution.  How about a new test/modules/gist/ then?
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: Add wal_fpi_bytes_[un]compressed to pg_stat_wal
Next
From: Bertrand Drouvot
Date:
Subject: Consistently use the XLogRecPtrIsInvalid() macro