Remove specific _\n code in TAP for Windows - Mailing list pgsql-hackers

From Michael Paquier
Subject Remove specific _\n code in TAP for Windows
Date
Msg-id aPsh39bxwYKvUlAf@paquier.xyz
Whole thread Raw
Responses Re: Remove specific _\n code in TAP for Windows
List pgsql-hackers
Hi all,

$subject has been mentioned by Jacob (in CC.) on Discord, and it does
not seem like somebody took the time to propose a patch.

We use in some places of the TAP tests the following pattern:
my $newline = $windows_os ? "\r\n" : "\n";

Two files have this idea:
- 003_ldap_connection_param_lookup.pl
- 006_service.pl
Note: I have committed one of these.

However, in light of 1c6d4629394d, we should not require that, and the
CI looks happy with the attached.

That would be up to the buildfarm to act as final judge, but any
objections in attempting to get rid of these like in the attached?
I would try first HEAD to be sure, then follow with an optional
backpatch.

Thoughts?
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: contrib/sepgsql regression tests have been broken for months
Next
From: Daniel Gustafsson
Date:
Subject: Re: Remove specific _\n code in TAP for Windows