Re: get rid of RM_HEAP2_ID - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: get rid of RM_HEAP2_ID
Date
Msg-id aPWSCnlH9y1DMTEP@paquier.xyz
Whole thread Raw
In response to Re: get rid of RM_HEAP2_ID  (Heikki Linnakangas <hlinnaka@iki.fi>)
List pgsql-hackers
On Wed, Oct 15, 2025 at 05:39:38PM +0300, Heikki Linnakangas wrote:
> We could store xl_crc unaligned. IIRC all the structs that follow that are
> already stored unaligned.

If we do just that, would there be any downside in moving xl_crc to be
just after xl_prev?  That would keep the record assembling part
simpler, because XLogRecord is treated as a single object, where the
code relies on a MAXALIGN64() to make sure that the header is aligned.
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Bryan Green
Date:
Subject: Re: [PATCH] Fix POSIX compliance in pgwin32_unsetenv()
Next
From: Michael Paquier
Date:
Subject: Re: Preserve index stats during ALTER TABLE ... TYPE ...