Re: remove partColsUpdated - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: remove partColsUpdated
Date
Msg-id aPCKnuDoLsU3br17@paquier.xyz
Whole thread Raw
In response to Re: remove partColsUpdated  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
On Wed, Oct 15, 2025 at 08:18:41PM -0400, Tom Lane wrote:
> Chao Li <li.evan.chao@gmail.com> writes:
>> On Oct 15, 2025, at 23:50, Nathan Bossart <nathandbossart@gmail.com> wrote:
>>> This was first added in commit 2f17844 (v11), and AFAICT it was only used
>>> for a variable named update_tuple_routing_needed in ExecInitModifyTable(),
>>> which was removed by commit c5b7ba4 (v14).  Any objections to removing it
>>> now?
>
>> Looks like this is only one assignment to it and nobody reads it. I don’t see a reason to retain it.
>
> I just had a look through https://codesearch.debian.net/ and couldn't
> find any evidence that any extensions are using it, so +1 to remove.

Yes, that feels OK.  I've also spent some time looking at what github
is able to refer to, but I can only find traces of forked code or
cloned repositories in the open, without specific uses for it.  +1.
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: Preserve index stats during ALTER TABLE ... TYPE ...
Next
From: Renzo Dani
Date:
Subject: Re: Extend documentation for pg_stat_replication.backend_xmin