Re: Remove custom redundant full page write description from GIN - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: Remove custom redundant full page write description from GIN
Date
Msg-id aOXzHsq8YYdxZ-RC@paquier.xyz
Whole thread Raw
In response to Re: Remove custom redundant full page write description from GIN  (Kirill Reshke <reshkekirill@gmail.com>)
List pgsql-hackers
On Tue, Oct 07, 2025 at 02:08:02PM +0500, Kirill Reshke wrote:
> Turns out we already use XLogRecGetData in assignment:  char *rec =
> XLogRecGetData(record). But I still did alter v2 patch a bit,
> introducing new variable xlrec, to avoid clunky casts between char *
> and ginxlogUpdateMeta.

For UPDATE_META_PAGE, ntuples == 0 could also mean that we may show
a lot of invalid block numbers, as well, which feels a bit pointless.
I have switched that to check InvalidBlockNumber instead.

While reviewing the whole, I have noticed that rightlink was missing
for INSERT_LISTPAGE, as well as the right/left children pages for
SPLIT.  I have added this information, applied the result.  Thanks!
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Bertrand Drouvot
Date:
Subject: Re: Add memory_limit_hits to pg_stat_replication_slots
Next
From: Amit Kapila
Date:
Subject: Re: Logical Replication of sequences