Re: Remove custom redundant full page write description from GIN - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: Remove custom redundant full page write description from GIN
Date
Msg-id aOS3MlTUTAm8GO8A@paquier.xyz
Whole thread Raw
In response to Re: Remove custom redundant full page write description from GIN  (Michael Paquier <michael@paquier.xyz>)
Responses Re: Remove custom redundant full page write description from GIN
List pgsql-hackers
On Wed, Oct 01, 2025 at 03:39:35PM +0900, Michael Paquier wrote:
> +                   int32       ntuples;
> +                   ntuples = ((ginxlogUpdateMeta *) rec)->ntuples;
> +                   appendStringInfo(buf, "ntuples: %d", ntuples);
>
> In 0002.  We have a routine for this type of assignments:
> XLogRecGetBlockData().  Let's use it here for clarity.

This should be XLogRecGetData(), not XLogRecGetBlockData(), as the
data is assigned to the record.  My apologies for the mistake.
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Amit Kapila
Date:
Subject: Re: Logical Replication of sequences
Next
From: Arseniy Mukhin
Date:
Subject: Re: GIN tries to form a tuple with a partial compressedList during insertion