Re: [PATCH] Add tests for Bitmapset - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: [PATCH] Add tests for Bitmapset
Date
Msg-id aNy4xV4Fa1m9lyXX@paquier.xyz
Whole thread Raw
In response to Re: [PATCH] Add tests for Bitmapset  (David Rowley <dgrowleyml@gmail.com>)
Responses Re: [PATCH] Add tests for Bitmapset
Re: [PATCH] Add tests for Bitmapset
List pgsql-hackers
On Wed, Oct 01, 2025 at 06:00:59PM +1300, David Rowley wrote:
> I didn't look at the coverage report, but on thinking about it,
> test_bitmapset.c's "PG_RETURN_NULL(); /* invalid input */" won't be
> covered as I stripped out all the tests which purposefully pass
> invalid input. You may not want it that way if you're keen to keep the
> coverage of the test module high as well as bitmapset.c

Yes, that's something I was just going through, with a result pretty
close to what you have sent, including the removal and replacement of
most of tests that were specific to the test module.  The prev/next
member coverage is still looking OK from here, though.

Thanks for the typos, I've missed these.
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: David Rowley
Date:
Subject: Re: [PATCH] Add tests for Bitmapset
Next
From: "Joel Jacobson"
Date:
Subject: Re: Optimize LISTEN/NOTIFY