Re: Remove unused for_all_tables field from AlterPublicationStmt - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: Remove unused for_all_tables field from AlterPublicationStmt
Date
Msg-id aNX_R1rY6AzQ25-k@paquier.xyz
Whole thread Raw
In response to Re: Remove unused for_all_tables field from AlterPublicationStmt  (Chao Li <li.evan.chao@gmail.com>)
List pgsql-hackers
On Fri, Sep 26, 2025 at 09:24:03AM +0800, Chao Li wrote:
> On Sep 26, 2025, at 04:47, Masahiko Sawada <sawada.mshk@gmail.com> wrote:
>> I found that the for_all_table field in the AlterPublicationStmt is
>> not used at all unless I'm missing something. I've attached the patch
>> for only master that removes it.
>
> Yep, based on code of gram.y and the doc, FOR ALL TABLE is only
> supposed by CREATE PUBLICATION.

Indeed, good catch.  There's no point for this field currently.  As
far as I can see it is wrong since 665d1fad99e7, so I am betting on a
rebase mistake when the original feature has been reviewed.
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Yugo Nagata
Date:
Subject: Re: Suggestion to add --continue-client-on-abort option to pgbench
Next
From: Yugo Nagata
Date:
Subject: Re: Suggestion to add --continue-client-on-abort option to pgbench