Re: Add support for entry counting in pgstats - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: Add support for entry counting in pgstats
Date
Msg-id aNSPHzt58lA_PO7L@paquier.xyz
Whole thread Raw
In response to Re: Add support for entry counting in pgstats  (Keisuke Kuroda <keisuke.kuroda.3862@gmail.com>)
List pgsql-hackers
On Wed, Sep 24, 2025 at 11:37:25AM +0900, Keisuke Kuroda wrote:
> Regarding the option name track_counts in PgStat_KindInfo.
> In my personal opinion, I was just wondering that it shares
> the same name as the GUC track_counts(pgstat_track_counts in the source code).
> If we want to make it clearer, renaming it to track_entry_counts
> could be one option.

Yes, that's a good point and I have missed the GUC part.  What you are
suggesting is cleaner overall with the flag added to the pgstats kind
info.

> (That said, I feel the GUC track_counts option has a mismatch
> between its role and its name...)

I doubt that we will rename this GUC at any point in the future.

Updated patch attached with the new name, as you are suggesting.
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Bharath Rupireddy
Date:
Subject: Re: Introduce XID age based replication slot invalidation
Next
From: Richard Guo
Date:
Subject: Re: Inconsistent Behavior of GROUP BY ROLLUP in v17 vs master