Re: "openssl" should not be optional - Mailing list pgsql-hackers

From Christoph Berg
Subject Re: "openssl" should not be optional
Date
Msg-id aNQKqD8bHmy05Z3p@msg.df7cb.de
Whole thread Raw
In response to Re: "openssl" should not be optional  (Daniel Gustafsson <daniel@yesql.se>)
Responses Re: "openssl" should not be optional
List pgsql-hackers
Re: Daniel Gustafsson
> Looking at this I was reminded that we already handle this by using a fallback
> and the test worked all along.  The message for this was quite poorly worded
> though, and used a warning instead of a note.  The attached will try to detect
> openssl being missing before trying to run it, and will skip the warning
> message if the fallback is used (which really isn't a warning in the first
> place).

Thanks, I just built the postgresql-18 again with this patch (and
openssl not installed [*]). It passes fine now.

In the meantime, I also got the report that postgresql-17 is not
failing in that environment, so the problem is new in 18.

> The ERROR in 003_sslinfo is intentional, we are testing that processing fails
> by passing an invalid value.

Ah, I was mentioning that in the original report because it only
showed up in the failing log, but that's just because the non-failing
build does not go scraping the test log files. That made the problem
look bigger than it actually was.

Thanks,
Christoph

[*] future builds will have openssl as build-dependency.



pgsql-hackers by date:

Previous
From: Laurenz Albe
Date:
Subject: Re: Built-in case-insensitive collation pg_unicode_ci
Next
From: Tom Lane
Date:
Subject: Re: GNU/Hurd portability patches