Re: TRAP: failed Assert("outerPlan != NULL") in postgres_fdw.c - Mailing list pgsql-bugs

On Thu, Oct 02, 2025 at 03:20:32PM -0700, Masahiko Sawada wrote:
> I've updated the patch based on your comments. Please find the attached patch.

Looks sensible here in shape, a few style nits noticed while reading.
x
+# This test exerices EvalPlanQual with a SubLink sub-select (which should
+# be unaffected by any EPQ recheck behavior in the outer query)

The setup phase has a mix of tabs (used in the DO block) and
spaces used, that may render weirdly depending on one's setup when
showing the diffs.  It looks to me that your intention is to use
spaces.

s/exerices/exercises/  And I would add a short explanation about the
reason why this script exists at the top of eval_plan_qual.spec.  If
you don't feel strongly about that, feel free to ignore me.

One other bit I have noticed on the way, due to the extra whitespaces
at the bottom of the file:
$ git diff master --check
contrib/postgres_fdw/specs/eval_plan_qual.spec:52: new blank line at EOF.
--
Michael