Request a Demo
Home   >   mailing lists

Re: [PATCH] Add tests for Bitmapset - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: [PATCH] Add tests for Bitmapset
Date
Msg-id aN8cCGZYN5oqjMRD@paquier.xyz
Whole thread Raw
In response to Re: [PATCH] Add tests for Bitmapset  (David Rowley <dgrowleyml@gmail.com>)
List pgsql-hackers
Tree view 
On Fri, Oct 03, 2025 at 12:36:57PM +1300, David Rowley wrote:
> I see test_random_operations() is also strict. Is it worth getting rid
> of the SQL NULL checks on the inputs there too? Aka, the attached.

Yes, this was not bothering me much.  Anyway, agreed about removing
these as well.  I cannot find an argument in favor of making the
function callable on NULL input with default values that are hardcoded
internally in the function.

Thanks, David and Daniel.
--
Michael
Attachment

pgsql-hackers by date:

Previous
From: torikoshia
Date:
Subject: Re: speedup COPY TO for partitioned table.
Next
From: Michael Paquier
Date:
Subject: Re: Support getrandom() for pg_strong_random() source