On Fri, Aug 15, 2025 at 11:39:23AM -0400, Greg Burd wrote:
> I noticed that there are no tests for Bitmapset in src/test/modules as
> is the case for other similar things like radixtree, rbtree, etc. so I
> created one. I realize that Bitmapset is already "tested" by all the
> other code that uses it, but I was able to find one minor oversight[1]
> in that code with these new tests.
>
> I hope I've covered all the bases, but if you have thoughts on other
> ways to test Bitmapset I'll happily add them to the patch.
Adding some tests here seems like a good idea. I might look into some ways
to trim it down a bit, but that'd just be minor editorialization. One
other thing to consider is adding randomness to the tests (see
test_radixtree and test_binaryheap for examples).
--
nathan
