Re: Improve LWLock tranche name visibility across backends - Mailing list pgsql-hackers

From Nathan Bossart
Subject Re: Improve LWLock tranche name visibility across backends
Date
Msg-id aLn4n-5UFzKHFdR5@nathan
Whole thread Raw
In response to Re: Improve LWLock tranche name visibility across backends  (Sami Imseih <samimseih@gmail.com>)
List pgsql-hackers
On Thu, Sep 04, 2025 at 12:30:27PM -0500, Sami Imseih wrote:
> I liked removing the repalloc calls inside this routine and did not think
> it was worth optimizing. I am OK with reverting it back. Although v1
> is incorrect since it's still initializing
> NamedLWLockTrancheRequestArray to MAX_NAMED_TRANCHES

Committed with that fix.

>> Furthermore, the
>> MAX_NAMED_TRANCHES check isn't actually needed because InitializeLWLocks()
>> will do the same check via its calls to LWLockNewTrancheId() for all the
>> named tranche requests.
> 
> I thought about that one and decided to add the error message there, since
> requesting a tranche happens way before LWLockNewTrancheId is called
> during CreateLWLocks, so it was more about erroring out slightly earlier.
> But it may be ok to also just remove it.

We needed it before because the array could only ever hold
MAX_NAMED_TRANCHES requests.

-- 
nathan



pgsql-hackers by date:

Previous
From: Andres Freund
Date:
Subject: Re: Stack-based tracking of per-node WAL/buffer usage
Next
From: Sami Imseih
Date:
Subject: Re: GetNamedLWLockTranche crashes on Windows in normal backend