On Sun, Aug 31, 2025 at 01:34:26PM +0200, Peter Eisentraut wrote:
> On 30.08.25 18:52, Tom Lane wrote:
> > Bruce Momjian <bruce@momjian.us> writes:
> > > Second, the release note item added by this commit:
> > > commit d1073c3b4cc
> > > Author: Peter Eisentraut <peter@eisentraut.org>
> > > Date: Fri Aug 29 10:18:10 2025 +0200
> >
> > > Unfortunately src/tools/add_commit_links.pl can't process the <ulink>
> > > and throws an error because the previous line does not end with a
> > > parenthesis. If I add "()" after the last line in the text block, it
> > > works fine, but obviously this is not acceptable.
> >
> > I suppose that the expectation is that every release note item
> > will be credited to someone. Why does this item lack a credit?
>
> Maybe I'm understanding this differently, but the "Migration" section ought
> to be advice about the migration, which is not a place to communicate
> credit. In the case I added, the item is the result of some changes that
> are already listed and credited elsewhere in the "Changes" section.
So, this gets back to the the actual purpose of giving credit, and we
have discussed this at length in the past. If an item is worth
mentioning in the release notes because of its impact on users, it is
worth adding attributions, since the attributions are small, and easily
skipped. What I have not done is to add items that do not fit that
criteria solely to give attribution, and that has upset some.
I have used the same criteria in the "Migration" section since I see no
reason to deviate from that policy in that section, and you will see
that in the PG 18 "Migration" section for other items. Years ago, I
think before I was adding commit hashes, I used to not attribute
migration items if they were referenced later, but at this point, with
the need for commit markers anyway, we might as well just repeat the
attribution to keep it consistent.
--
Bruce Momjian <bruce@momjian.us> https://momjian.us
EDB https://enterprisedb.com
Do not let urgent matters crowd out time for investment in the future.
