On Sat, Aug 30, 2025 at 12:52:45PM -0400, Tom Lane wrote:
> Bruce Momjian <bruce@momjian.us> writes:
> > Second, the release note item added by this commit:
> > commit d1073c3b4cc
> > Author: Peter Eisentraut <peter@eisentraut.org>
> > Date: Fri Aug 29 10:18:10 2025 +0200
>
> > Unfortunately src/tools/add_commit_links.pl can't process the <ulink>
> > and throws an error because the previous line does not end with a
> > parenthesis. If I add "()" after the last line in the text block, it
> > works fine, but obviously this is not acceptable.
>
> I suppose that the expectation is that every release note item
> will be credited to someone. Why does this item lack a credit?
I don't know.
> If we're okay with items not having credits, then
> add_commit_links.pl's logic for where to put the <ulink>s needs
> improvement. I don't really understand why it's looking for
> parens in the first place -- why isn't the rule simply "put them
> before the first </para> in the item"?
I wrote the code to insert the <ulink> when we are not in a comment,
when the line is a </para>, _and_ the previous line ends with a
parenthesis. Maybe that was overkill, but I wanted to be as restrictive
as possible.
Actually, in this case, it caught an obvious missing attribution, so it
actually helped, so let's not change it. I will add an attribution to
Peter Eisentraut now with the attached patch. I also rewrote the item
to better match the surrounding text.
> In either case, I don't agree with hacky workarounds like manually
> munged ulink entries ...
>
> > I can commit this once our RC1 git tree freeze is over. Is that Tuesday?
>
> The release freeze doesn't apply to the release notes ;-)
Done. ;-)
--
Bruce Momjian <bruce@momjian.us> https://momjian.us
EDB https://enterprisedb.com
Do not let urgent matters crowd out time for investment in the future.
