On Sat, Aug 30, 2025 at 06:04:16PM -0400, Tom Lane wrote:
> Bruce Momjian <bruce@momjian.us> writes:
> > Actually, in this case, it caught an obvious missing attribution, so it
> > actually helped, so let's not change it.
>
> Fair enough. I'd still like to put in the bit about
>
> my $major_version = $1;
> + die "file name $file is not in the expected format\n"
> + unless defined $major_version;
>
> because the existing code does not behave nicely at all if you
> point it at an incorrect file name.
Good fix, done.
> > I will add an attribution to
> > Peter Eisentraut now with the attached patch. I also rewrote the item
> > to better match the surrounding text.
>
> Hmm, this text has *two* attributions to Peter, and
> add_commit_links.pl disagrees with you on where to put the URL.
Oops, fixed.
--
Bruce Momjian <bruce@momjian.us> https://momjian.us
EDB https://enterprisedb.com
Do not let urgent matters crowd out time for investment in the future.
