Re: ReplicationSlotRelease() crashes when the instance is in the single user mode - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: ReplicationSlotRelease() crashes when the instance is in the single user mode
Date
Msg-id aKRdXV8o56mUl_gm@paquier.xyz
Whole thread Raw
In response to RE: ReplicationSlotRelease() crashes when the instance is in the single user mode  ("Hayato Kuroda (Fujitsu)" <kuroda.hayato@fujitsu.com>)
Responses RE: ReplicationSlotRelease() crashes when the instance is in the single user mode
List pgsql-hackers
On Tue, Aug 19, 2025 at 10:26:22AM +0000, Hayato Kuroda (Fujitsu) wrote:
> I added a first version of the test. It could work on my env (Linux).

You could also validate that using the CI, assuming that you have a
cloned repo on github with the CI enabled.  See src/tools/ci/README.
I use that a lot with local branches for pre-commit validations where
things could break across the board.

> Since I cannot come up the appropriate place, I introduced new test file in
> recovery test. creating/dropping/advancing a slot, and doing a logical decoding
> is tested. Since standby mode is not supported by the single-user instance,
> I did not test the slot synchronization. I have not known that.

Hmm.  src/test/modules/test_misc/ makes more sense to me here.  (No
need to send an updated patch just for that.)

> IIUC, 0001 can be backpatched for all supported branches. I will create for them
> after patch would be a good shape.

Thanks, I'll check all that tomorrow.
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: "Hayato Kuroda (Fujitsu)"
Date:
Subject: RE: ReplicationSlotRelease() crashes when the instance is in the single user mode
Next
From: Matheus Alcantara
Date:
Subject: Re: LISTEN/NOTIFY bug: VACUUM sets frozenxid past a xid in async queue