Re: fix ancient typo in transformRelOptions() - Mailing list pgsql-hackers

From Nathan Bossart
Subject Re: fix ancient typo in transformRelOptions()
Date
Msg-id aJK72dWoPnTZrB63@nathan
Whole thread Raw
In response to Re: fix ancient typo in transformRelOptions()  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: fix ancient typo in transformRelOptions()
List pgsql-hackers
On Tue, Aug 05, 2025 at 06:10:54PM -0400, Tom Lane wrote:
> =?utf-8?Q?=C3=81lvaro?= Herrera <alvherre@kurilemu.de> writes:
>> On 2025-Aug-05, Nathan Bossart wrote:
>>> I noticed that this function has a "namspace" parameter.  The attached
>>> patch adds the missing 'e'.
> 
>> I have vague recollections of it being this way because of "namespace"
>> being a C++ keyword.  (commit is 3a5b77371522, but I don't have energy
>> to look for the discussion right now.)
> 
> Oh, duh -- if you try cpluspluscheck you'll find it's unhappy.
> I didn't locate the discussion of "namspace" either, but I did
> notice that de160e2c0 used "nameSpace" for the same purpose.
> Maybe we should standardize on that?  It looks less like a typo
> than "namspace", for sure.

That explains it.  I didn't find any past discussions about this particular
name, but commit de160e2 was being developed concurrently.  I'll use
nameSpace instead.

-- 
nathan



pgsql-hackers by date:

Previous
From: Ajin Cherian
Date:
Subject: Re: Improve pg_sync_replication_slots() to wait for primary to advance
Next
From: shveta malik
Date:
Subject: Re: Improve pg_sync_replication_slots() to wait for primary to advance