On Mon, Jul 28, 2025 at 03:38:20PM +0900, Michael Paquier wrote:
> On Sun, Jul 27, 2025 at 12:50:54PM -0700, Lukas Fittl wrote:
>> - Fix a typo (configure was incorrectly checking for "__get_cpuidex", vs
>> meson.build was doing it correctly)
>
> It seems to me that this is an independent issue that had better be
> backpatched down to where this configure check has been introduced,
> no?
Please note that updates of ./configure should never be manual, these
are done as follows:
- Update of ./autoconf.ac
- run of autoreconf -i or equivalent to update ./configure. (I just
use the former, just my no-brainer to handle things. Committers are
usually responsible for that, but it may matter to keep the CI happy.)
And I have noticed a second inconsistency with __cpuid(), both
introduced by 3dc2d62d0486 as far as I can see, so we have never
checked for these routines. This is an independent issue for
something that should be backpatched, so I've spawned a new thread
(don't worry you have author credits):
https://www.postgresql.org/message-id/aIgwNYGVt5aRAqTJ@paquier.xyz
--
Michael
