Re: Bogus bitmasking in heap2_desc - Mailing list pgsql-hackers

From Julien Rouhaud
Subject Re: Bogus bitmasking in heap2_desc
Date
Msg-id aIcLIxVpPQ2MHj2P@jrouhaud
Whole thread Raw
In response to Re: Bogus bitmasking in heap2_desc  (Michael Paquier <michael@paquier.xyz>)
Responses Re: Bogus bitmasking in heap2_desc
List pgsql-hackers
Hi,

On Mon, Jul 28, 2025 at 02:27:43PM +0900, Michael Paquier wrote:
>
> The relationship between XLOG_HEAP_OPMASK and heap2 is documented in
> heapam_xlog.h.  XLOG_HEAP2_MULTI_INSERT may have XLOG_HEAP_INIT_PAGE
> set, so if we don't filter the contents from XLogRecGetInfo() then the
> record description becomes incorrect for the XLOG_HEAP2_MULTI_INSERT
> "MULTI_INSERT+INIT" case, no?
>
> Apologies if I am missing your point.

Ah I'm the one apologizing, I totally missed that comment.

Thanks for the pointing it out.



pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: Bogus bitmasking in heap2_desc
Next
From: Ashutosh Bapat
Date:
Subject: Re: [Proposal] Expose internal MultiXact member count function for efficient monitoring