Bogus bitmasking in heap2_desc - Mailing list pgsql-hackers

From Julien Rouhaud
Subject Bogus bitmasking in heap2_desc
Date
Msg-id aIXvPP62qfTbL4m0@jrouhaud
Whole thread Raw
Responses Re: Bogus bitmasking in heap2_desc
List pgsql-hackers
Hi,

heap2_desc apparently inherited the extra bit filtering from heap_desc to
ignore XLOG_HEAP_INIT_PAGE.  But XLOG_HEAP2 only has real opcodes in the
high bits there is no reason why there should be this filtering, and even if it
eventually needed additional filtering we would need something specific to this
resource manager anyway, so I think we can get rid of it as in the attached.

Attachment

pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: IndexAmRoutine aminsertcleanup function can be NULL?
Next
From: Etsuro Fujita
Date:
Subject: Re: [(known) BUG] DELETE/UPDATE more than one row in partitioned foreign table