Re: Can can I make an injection point wait occur no more than once? - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: Can can I make an injection point wait occur no more than once?
Date
Msg-id aHG3-kd6LH0S6QKy@paquier.xyz
Whole thread Raw
In response to Re: Can can I make an injection point wait occur no more than once?  (Peter Geoghegan <pg@bowt.ie>)
List pgsql-hackers
On Thu, Jul 10, 2025 at 06:58:58PM -0400, Peter Geoghegan wrote:
> On Wed, Jul 9, 2025 at 10:24 PM Noah Misch <noah@leadboat.com> wrote:
> > Looking at .cirrus.tasks.yml, I bet the key factor is that CI task using
> > debug_parallel_query=regress.  I bet the leader is attached to the injection
> > point, but the WARNING is reached in a parallel worker.
>
> Yep, that was it.

Catching up on things a bit.  Cool to see that you have found out the
origin of the problem.

> At some point I'll start a new thread with a formal patch proposal,
> that'll include the tests on this thread. I also plan on using
> injection points to write a simple/serial regression test exercising
> the nbtree code that completes an incomplete split (following a hard
> crash/error).

It sounds to me that an ERROR in an SQL and/or isolation test would be
enough.  If you are looking at some replay cases, a TAP test would be
the way to go.
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Paul Jungwirth
Date:
Subject: Re: Foreign key isolation tests
Next
From: Michael Paquier
Date:
Subject: Re: pg_logical_slot_get_changes waits continously for a partial WAL record spanning across 2 pages