Re: pgsql: Fix cross-version upgrade test breakage from commit fe07100e82. - Mailing list pgsql-committers

From Nathan Bossart
Subject Re: pgsql: Fix cross-version upgrade test breakage from commit fe07100e82.
Date
Msg-id aGWMKkLhTmCnCO1N@nathan
Whole thread Raw
In response to Re: pgsql: Fix cross-version upgrade test breakage from commit fe07100e82.  (Andrew Dunstan <andrew@dunslane.net>)
List pgsql-committers
On Wed, Jul 02, 2025 at 03:43:02PM -0400, Andrew Dunstan wrote:
> On 2025-07-02 We 2:27 PM, Nathan Bossart wrote:
>> To fix, revert those renames.  I could probably get away with only
>> un-renaming the C symbols, but I figured I'd avoid introducing
>> function name mismatches.  Also, AFAICT the buildfarm's
>> cross-version upgrade tests do not run the test module tests
>> post-upgrade, else we'll need to properly version the extension.
> 
> It doesn't really run any sanity checks at all other than amchecks.. It just
> compares the pre- and post- upgrade dumps (with suitable modifications).
> 
> So far that seems to have been enough.

Thanks for confirming.

-- 
nathan



pgsql-committers by date:

Previous
From: Andrew Dunstan
Date:
Subject: Re: pgsql: Fix cross-version upgrade test breakage from commit fe07100e82.
Next
From: Tom Lane
Date:
Subject: pgsql: Correctly copy the target host identification in PQcancelCreate.