Re: CHECKPOINT unlogged data - Mailing list pgsql-hackers

From Christoph Berg
Subject Re: CHECKPOINT unlogged data
Date
Msg-id aEL6sDr9RxdSkPm-@msg.df7cb.de
Whole thread Raw
In response to Re: CHECKPOINT unlogged data  (Fujii Masao <masao.fujii@oss.nttdata.com>)
Responses Re: CHECKPOINT unlogged data
List pgsql-hackers
Re: Fujii Masao
> utility.c:946:4: warning: label followed by a declaration is a C23 extension [-Wc23-extensions]

Thanks, my compiler didn't throw that. { } block added in v3.

>             RequestCheckpoint(CHECKPOINT_WAIT |
> +                              (immediate ? CHECKPOINT_IMMEDIATE : 0) |
> +                              (flush_all ? CHECKPOINT_FLUSH_ALL : 0) |
> 
> Some users might want to trigger a spread checkpoint but not wait for
> it to finish, since it could take a long time? If that's a valid use case,
> maybe we should add a WAIT option to let users choose whether to wait for
> the checkpoint to complete or not?

Do we want that? The checkpoint is only effective when it's finished,
and running `psql -c "checkpoint (wait false)"` might make people
shoot themselves into the foot.

Christoph

Attachment

pgsql-hackers by date:

Previous
From: Bruce Momjian
Date:
Subject: Re: Enable data checksums by default
Next
From: Sami Imseih
Date:
Subject: Re: [PATCH] Re: Proposal to Enable/Disable Index using ALTER INDEX