Re: Do we still need MULE_INTERNAL? - Mailing list pgsql-hackers

From Jeff Davis
Subject Re: Do we still need MULE_INTERNAL?
Date
Msg-id a99a7ccc88e2939b047845230a55fe02528b4e7c.camel@j-davis.com
Whole thread Raw
In response to Re: Do we still need MULE_INTERNAL?  (Thomas Munro <thomas.munro@gmail.com>)
Responses Re: Do we still need MULE_INTERNAL?
List pgsql-hackers
On Thu, 2026-02-12 at 03:06 +1300, Thomas Munro wrote:
> On Wed, Feb 11, 2026 at 7:52 PM Tatsuo Ishii <ishii@postgresql.org>
> wrote:
> > Thank you for the report. I find it is quite useful, especially the
> > Emacs 23 internal (new to me). I agree that MULE_INTERNAL has
> > fulfilled its historic role.
>
> Thanks Ishii-san and Tom.  Here's a patch.  Obviously it mostly just
> deletes thousands of lines, but also: I had to preserve the encoding
> number, so there's a hole in the table, 

pg_upgrade fails:

  Performing Upgrade
  ------------------
  ...
  Setting frozenxid and minmxid counters in new cluster
connection to server on socket "/.../.s.PGSQL.50432" failed: FATAL:
invalid database encoding: 7

You should have an explicit check.

Other than that, it looks good to me.

> and I had to think of a new
> name for cyrillic_and_mic.c, so I went with cyrillic.c because it
> handles 4 single-byte encodings and it wasn't clear how to fit into
> the existing x_and_y pattern (ie which two to highlight arbitrarily
> in
> the name).

Seems fine.

Regards,
    Jeff Davis




pgsql-hackers by date:

Previous
From: Heikki Linnakangas
Date:
Subject: Re: Shared hash table allocations
Next
From: Roberto Mello
Date:
Subject: Re: pg_publication_tables: return NULL attnames when no column list is specified