Re: relcache sometimes initially ignores has_generated_stored - Mailing list pgsql-hackers

From Peter Eisentraut
Subject Re: relcache sometimes initially ignores has_generated_stored
Date
Msg-id a9615ad4-9063-4089-e740-d74b118e984c@2ndquadrant.com
Whole thread Raw
In response to relcache sometimes initially ignores has_generated_stored  (Andres Freund <andres@anarazel.de>)
Responses Re: relcache sometimes initially ignores has_generated_stored
List pgsql-hackers
On 2020-01-15 19:11, Andres Freund wrote:
>     /*
>      * Set up constraint/default info
>      */
>     if (has_not_null || ndef > 0 ||
>         attrmiss || relation->rd_rel->relchecks)
> test, i.e. there are no defaults.

> It does still strike me as not great that we can get a different
> relcache entry, even if transient, depending on whether there are other
> reasons to create a TupleConstr. Say a NOT NULL column.
> 
> I'm inclined to think we should just also check has_generated_stored in
> the if quoted above?

Fixed that way.

-- 
Peter Eisentraut              http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services



pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: Feature improvement: can we add queryId for pg_catalog.pg_stat_activityview?
Next
From: Robert Haas
Date:
Subject: Re: Internal key management system