Postgres Pro
Downloads
Home   >   mailing lists

Re: Bogus HAVE_DECL_FOO entries in msvc/Solution.pm - Mailing list pgsql-hackers

From Peter Eisentraut
Subject Re: Bogus HAVE_DECL_FOO entries in msvc/Solution.pm
Date
Msg-id a8d24099-6570-c18a-ae16-bcd221a5eada@enterprisedb.com
Whole thread Raw
In response to Bogus HAVE_DECL_FOO entries in msvc/Solution.pm  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
Tree view 
On 13.07.21 01:46, Tom Lane wrote:
> Autoconf's AC_CHECK_DECLS always defines HAVE_DECL_whatever
> as 1 or 0, but some of the entries in msvc/Solution.pm show
> such symbols as "undef" instead.  Shouldn't we fix it as
> per attached?  This is probably only cosmetic at the moment,
> but it could bite us someday if someone wrote a complex
> conditional using one of these symbols.

Yes, I think that is correct.

pgsql-hackers by date:

Previous
From: "r.takahashi_2@fujitsu.com"
Date:
Subject: RE: Transactions involving multiple postgres foreign servers, take 2
Next
From: Tom Lane
Date:
Subject: Re: Bogus HAVE_DECL_FOO entries in msvc/Solution.pm