On 02.06.21 23:27, Andrew Dunstan wrote:
>>> <short-version-comments.patch>
>> It's not the fault of your patch, but the docs seem to be misleading in ways that your comments don't fix. (Or
perhapsmy Windows knowledge is just too lacking to realize why these instructions are ok?)
>>
>> Prior to where your patch makes changes, the docs say, "If you are building PostgreSQL for Microsoft Windows, read
thischapter if you intend to build with MinGW or Cygwin". I think going on to tell the users to use `su` is a bit odd.
Does that exist in standard MinGW and Cygwin environments? I thought "run as" was the Windows option for this.
>>
>
> Yes, good point. We should fix that. Yes, "runas" is a sort of su.
> There's no adduser either.
I think those instructions were written before "sudo" became common.
Maybe we should update them a bit.
