On 02.06.26 08:28, Ashutosh Bapat wrote:
> I like the idea of pfree'ing the string returned by
> getObjectDescriptor() since we also pffree other descriptor strings.
> But just doing it for these changes doesn't look consistent.
>
> Attached patchset with some more changes to bring the new code inline
> with the surrounding code. The changes are
> 1. rename objdesc to rel. The latter is used in the surrounding code.
> 2. getObjectDescriptor() is invoked directly from appendStringInfo.
> 3. Place InitStringInfo() closer to the appendStringInfo call like
> surrounding code
>
> None of these changes are compulsory. If you think any of the changes
> are acceptable to you, please provide a single patch absorbing them
> into your patch. Otherwise, let the committer decide.
>
> 0008 is your patch as is
> 0009 is my cosmetic changes
committed
