Hi,
On 8/26/22 19:21, Tom Lane wrote:
> Nazir Bilal Yavuz <byavuz81@gmail.com> writes:
>> Based on these discussions, I attached a patch.
>
> I think the right fix is to call uuid_create and then actually check
> the version field of the result. This avoids breaking what need not
> be broken, and it'd also guard against comparable problems on other
> platforms (so don't blame NetBSD specifically in the message, either).
I updated my patch. I checked version field in 'uuid_generate_internal'
function instead of checking it in 'uuid_generate_v1' and
'uuid_generate_v1mc' functions, but I have some questions:
1 - Should it be checked only for '--with-uuid=bsd' option?
1.1 - If it is needed to be checked only for '--with-uuid=bsd',
should just NetBSD be checked?
2 - Should it error out without including current UUID version in the
error message? General error message could mask if the 'uuid_create'
function starts to produce UUIDs other than version-4.
Regards,
Nazir Bilal Yavuz
