[HACKERS] How to submit a patch. - Mailing list pgsql-hackers

From David Friend
Subject [HACKERS] How to submit a patch.
Date
Msg-id a59855e11845c2ffdca2dc33e2513ba6
Whole thread Raw
List pgsql-hackers
On Sun, 1 Jun 1997, Sean Lyndersay wrote:

> When running regression tests on my system (DEC Alpha running OSF1 v4.0
> Release 564), several tests fail. Some key ones include the int2 and int4,
> but these are caused by changes in the error messages for certain tests.

This can't be helped.  The error messages differ on different machines.
The tests that "fail" on your machine pass on mine and many others.  I
would suggest you don't submit patches to change these.

> I changed the expected files, but came up against another problem: simply
> put, what is the preferred method for submitting a patch?

Here is how I do it.  (I got this from Thomas Lockhart.):

  1) Create directory /usr/src/pgsql/patches, e.g.
       mkdir /usr/src/pgsql/patches

  2) Make a backup of the files you will change, e.g.
       cd /usr/src/pgsql/src/man
       cp psql.1 psql.1.orig

  3) Edit the files, e.g.
       vi psql.1

  4) Make the patch by using diff from the patch directory, e.g.
       cd /usr/src/pgsql/patches
       diff -c ../src/man/psql.1.orig ../src/man/psql.1 > psql.1.patch

  5) E-mail this patch to pgsql-patches@postgresql.org.  Describe the
     purpose of the patch at the top of the message.  Then include
     the text in the patch file (e.g. psql.1.patch).

David Friend                ! cq995@freenet.carleton.ca
Atlantis Scientific Inc.        ! david.friend@atlsci.com
20 Colonnade Rd, Suite 110        ! 613-727-1087 (voice)
Ottawa, Ontario, CANADA  K2E 7M6    ! 800-265-3894 (voice)
ERGOvista Scientific Image Analysis    ! 613-727-5853 (fax)

------------------------------

pgsql-hackers by date:

Previous
From: Bruce Momjian
Date:
Subject: [HACKERS] 6.1 issues resolved
Next
From: "Vadim B. Mikheev"
Date:
Subject: fixed: Re: [HACKERS] Bug in CREATE TABLE