Re: executor relation handling - Mailing list pgsql-hackers

From Amit Langote
Subject Re: executor relation handling
Date
Msg-id a20151ff-9d3b-bec8-8c64-5336676cfda3@lab.ntt.co.jp
Whole thread Raw
In response to Re: executor relation handling  (Jesper Pedersen <jesper.pedersen@redhat.com>)
Responses Re: executor relation handling  (David Rowley <david.rowley@2ndquadrant.com>)
List pgsql-hackers
Thanks again, Jesper.

On 2018/09/13 20:27, Jesper Pedersen wrote:
> Hi Amit,
> 
> On 9/13/18 12:58 AM, Amit Langote wrote:
>> Attached updated patches.
>>
>> Beside the issue that caused eval-plan-qual isolation test to crash, I
>> also spotted and fixed an oversight in the 0002 patch which would lead to
>> EState.es_output_cid being set to wrong value and causing unexpected error
>> during tuple locking as result of that.
>>
> 
> Thanks for the update.
> 
> However, the subscription TAP test
> (src/test/subscription/t/001_rep_changes.pl) is still failing.
> 
> CFBot has the same log
> 
>  https://travis-ci.org/postgresql-cfbot/postgresql/builds/427999969
> 
> as locally.

My bad.  I missed that logical replication code depends on the affected
executor code.

Fixed patches attached.

Thanks,
Amit

Attachment

pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: Cache lookup errors with functions manipulation object addresses
Next
From: Kyotaro HORIGUCHI
Date:
Subject: Re: hot_standby_feedback vs excludeVacuum and snapshots