Re: Handle infinite recursion in logical replication setup - Mailing list pgsql-hackers

From Peter Eisentraut
Subject Re: Handle infinite recursion in logical replication setup
Date
Msg-id a1a8b807-623d-b155-6f88-705afaf96df1@eisentraut.org
Whole thread Raw
In response to Re: Handle infinite recursion in logical replication setup  (Peter Smith <smithpb2250@gmail.com>)
List pgsql-hackers
On 09.08.23 04:50, Peter Smith wrote:
> On Tue, Aug 8, 2023 at 6:52 PM Amit Kapila <amit.kapila16@gmail.com> wrote:
>>
>> On Tue, Aug 8, 2023 at 1:50 PM Peter Eisentraut <peter@eisentraut.org> wrote:
>>>
>>> This patch added the following error message:
>>>
>>> errdetail_plural("Subscribed publication %s is subscribing to other
>>> publications.",
>>> "Subscribed publications %s are subscribing to other publications.",
>>> list_length(publist), pubnames->data),
>>>
>>> But in PostgreSQL, a publication cannot subscribe to a publication, so
>>> this is not giving accurate information.  Apparently, what it is trying
>>> to say is that
>>>
>>> The subscription that you are creating subscribes to publications that
>>> contain tables that are written to by other subscriptions.
>>>
>>> Can we get to a more accurate wording like this?
>>>
>>
>> +1 for changing the message as per your suggestion.
>>
> 
> PSA a patch to change this message text. The message now has wording
> similar to the suggestion.

committed, thanks




pgsql-hackers by date:

Previous
From: Shaun Thomas
Date:
Subject: Re: Logging of matching pg_hba.conf entry during auth skips trust auth, potential security issue
Next
From: Peter Eisentraut
Date:
Subject: dubious warning: FORMAT JSON has no effect for json and jsonb types