Postgres Pro
Downloads
Home   >   mailing lists

Re: [PATCH] Add crc32(text) & crc32(bytea) - Mailing list pgsql-hackers

From Peter Eisentraut
Subject Re: [PATCH] Add crc32(text) & crc32(bytea)
Date
Msg-id a182edc7-c558-47c6-9ab0-94c4dd970e3b@eisentraut.org
Whole thread Raw
In response to Re: [PATCH] Add crc32(text) & crc32(bytea)  (Nathan Bossart <nathandbossart@gmail.com>)
Responses Re: [PATCH] Add crc32(text) & crc32(bytea)
List pgsql-hackers
Tree view 
On 05.08.24 17:28, Nathan Bossart wrote:
> This looks pretty good to me.  The only point that I think deserves more
> discussion is the return type.  Does bytea make the most sense here?  Or
> should we consider int/bigint?

The correct return type of a CRC operation in general is some kind of 
exact numerical type.  Just pick the best one that fits the result.  I 
don't think bytea is appropriate.

pgsql-hackers by date:

Previous
From: Tender Wang
Date:
Subject: Re: [BUG] Fix DETACH with FK pointing to a partitioned table fails
Next
From: Nathan Bossart
Date:
Subject: Re: [PATCH] Add crc32(text) & crc32(bytea)