Re: Add a write_to_file member to PgStat_KindInfo - Mailing list pgsql-hackers

From Bertrand Drouvot
Subject Re: Add a write_to_file member to PgStat_KindInfo
Date
Msg-id Zz70G7GbQklQEdUD@ip-10-97-1-34.eu-west-3.compute.internal
Whole thread Raw
In response to Re: Add a write_to_file member to PgStat_KindInfo  (Nazir Bilal Yavuz <byavuz81@gmail.com>)
List pgsql-hackers
Hi,

On Thu, Nov 21, 2024 at 04:26:47PM +0900, Michael Paquier wrote:
> On Thu, Nov 21, 2024 at 06:32:03AM +0000, Bertrand Drouvot wrote:
> > That was in fact the main reason why I added this test. But well, just 
> > adding the "write_to_file" in the injection test is enough to "show" that this
> > member does exist. So I'm fine with v3.
> 
> Plus/minus some tweaks in the wordings (like a s/stat /stats /),

I think the singular was ok here, but v4 (just shared up-thread) uses your
proposal.

Regards,

-- 
Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com



pgsql-hackers by date:

Previous
From: Masahiro Ikeda
Date:
Subject: Re: Adding skip scan (including MDAM style range skip scan) to nbtree
Next
From: Christoph Berg
Date:
Subject: Re: 039_end_of_wal: error in "xl_tot_len zero" test