Re: minor doc issue in 9.16.2.1.1. Boolean Predicate Check Expressions - Mailing list pgsql-hackers

On Tue, Nov  5, 2024 at 05:24:07PM +0800, jian he wrote:
> On Thu, Oct 31, 2024 at 11:51 PM Bruce Momjian <bruce@momjian.us> wrote:
> >
> > On Fri, Oct 18, 2024 at 10:00:54AM +0800, jian he wrote:
> > > On Fri, Oct 18, 2024 at 2:05 AM Bruce Momjian <bruce@momjian.us> wrote:
> > > > Yes, updated patch attached.
> > > >
> > > looks good.
> > >
> > > in the meantime, do you think it's necessary to slightly rephrase
> > > jsonb_path_match doc entry:
> > >
> > > currently doc entry:
> > > jsonb_path_match ( target jsonb, path jsonpath [, vars jsonb [, silent
> > > boolean ]] ) → boolean
> > > Returns the result of a JSON path predicate check for the specified JSON value.
> > >
> > >
> > > "the result of a JSON path predicate check for the specified JSON
> > > value." is a jsonb boolean.
> > > but jsonb_path_match returns sql boolean.
> > > maybe add something to describe case like: "if JSON path predicate
> > > check return jsonb null, jsonb_path_match will return SQL null".
> >
> > Yes, I think that is a good point, updated patch attached.
> >
> 
> played with
> https://www.postgresql.org/docs/current/functions-json.html#FUNCTIONS-SQLJSON-FILTER-EX-TABLE
> 
> The patch  looks good to me.

Patch applied back to PG 17.

-- 
  Bruce Momjian  <bruce@momjian.us>        https://momjian.us
  EDB                                      https://enterprisedb.com

  When a patient asks the doctor, "Am I going to die?", he means 
  "Am I going to die soon?"