Re: Use more CppAsString2() in pg_amcheck.c - Mailing list pgsql-hackers

From Nathan Bossart
Subject Re: Use more CppAsString2() in pg_amcheck.c
Date
Msg-id ZxKZUprDJOkRmET4@nathan
Whole thread Raw
List pgsql-hackers
On Fri, Oct 18, 2024 at 06:50:50PM +0900, Michael Paquier wrote:
> -    appendPQExpBufferStr(&sql, "\nWHERE c.relpersistence != 't'");
> +    appendPQExpBufferStr(&sql, "\nWHERE c.relpersistence != "
> +                         CppAsString2(RELPERSISTENCE_TEMP) " ");

I think these whitespace changes may cause invalid statements to be
produced in some code paths.  IMHO those should be reserved for a separate
patch, anyway.

-- 
nathan



pgsql-hackers by date:

Previous
From: Nathan Bossart
Date:
Subject: Re: Proposal for Updating CRC32C with AVX-512 Algorithm.
Next
From: Tom Lane
Date:
Subject: Re: ECPG Refactor: move sqlca variable in ecpg_log()